[RFC][arith] Add extended multiplication ops
Hi folks, I propose to add 2 new ops to the arith dialect: %low, %high = arith.mului_extended %a, %b : iN – extended unsigned multiplication %low, %high = arith.mulsi_extended %a, %b : iN – extended...
View Article[RFC][arith] Add extended multiplication ops
+1. Thanks Jakub for the RFC! Having this to enable a more principled lowering path makes sense to me. Read full topic
View Article[RFC][arith] Add extended multiplication ops
Thanks for the proposal, Jakub! Just passing by and thought this information could be useful: RISC-V (and more architectures, lately) also has “widening” instructions where you can represent an i2N...
View Article[RFC][arith] Add extended multiplication ops
Thanks for the context, @dcaballe. I think I can understand the appeal of returning i2N, but I also see a few issues: This would create asymmetry compared to the existing add with overflow ops:...
View ArticleClik here to view.
[RFC][arith] Add extended multiplication ops
Nice to see support for this, and looking forward to the emulation support. kuhar: There’s not direct counterpart in LLVM What is the plan for lowering to LLVM? kuhar: Efficient lowering of...
View ArticleClik here to view.
[RFC][arith] Add extended multiplication ops
_sean_silva: What is the plan for lowering to LLVM? I was under the impression that in llvm it’s generally fine to introduce wide integer types and rely on the pass pipeline to eventually legalize...
View Article[RFC][arith] Add extended multiplication ops
Could you instead introduce an intrinsic in LLVM? The intent would be clear. It gives more control to LLVM how to handle the operation. Read full topic
View Article[RFC][arith] Add extended multiplication ops
We can do that if the others who have stakes in the LLVM side of things are onboard. However, I’d like to avoid arith and llvm being codependent like I argued here: [RFC] Define precise arith...
View Article[RFC][arith] Add extended multiplication ops
FYI, I’ve just submitted the first patch for review: ⚙ D139688 [mlir][arith] Define mului_extended op Read full topic
View Article
